Respect a requeue after if it’s set in case the error wraps ErrQuiet#3
Draft
annismckenzie wants to merge 3 commits intomainfrom
Draft
Respect a requeue after if it’s set in case the error wraps ErrQuiet#3annismckenzie wants to merge 3 commits intomainfrom
ErrQuiet#3annismckenzie wants to merge 3 commits intomainfrom
Conversation
annismckenzie
force-pushed
the
0-honor-requeue-after-if-returned-by-reconciler
branch
from
750be0a to
0835fed
Compare
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.48.0 to 0.49.0. - [Commits](golang/net@v0.48.0...v0.49.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.49.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…io#674) * Bump sigs.k8s.io/controller-runtime from 0.22.4 to 0.23.1 Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.22.4 to 0.23.1. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.22.4...v0.23.1) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.23.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Basic support for upstream status client apply Signed-off-by: Scott Andrews <scott@andrews.me> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Scott Andrews <scott@andrews.me> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Scott Andrews <scott@andrews.me>
Signed-off-by: Daniel Lohse <info@asapdesign.de>
annismckenzie
force-pushed
the
0-honor-requeue-after-if-returned-by-reconciler
branch
from
0835fed to
6acf813
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the last remaining issue we have with the latest release. It's tracked in reconcilerio#653 but I needed an up-to-date version with just that single fix.